Refactor remaining non-request usages of the GenericSignatureBuilder #39826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
encapsulate-gsb
branch
from
0fcab5a
to
a9794dc
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places were creating GenericSignatureBuilders directly instead of using AbstractGenericSignatureRequest / InferredGenericSignatureRequest. Refactor these after generalizing InferredGenericSignatureRequest slightly to handle the new use case of
whereclauses written in attributes (@differentiableand@_specialize). This is of course a stepping stone to introducing the RequirementMachine's generic signature minimization algorithm, and removing the GenericSignatureBuilder entirely.